Fix PHP 8.4 / 8.5 deprecations (implicit nullable params, curl_close)#293
Open
jpxd wants to merge 4 commits into
Open
Fix PHP 8.4 / 8.5 deprecations (implicit nullable params, curl_close)#293jpxd wants to merge 4 commits into
jpxd wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the library clean under PHP 8.4 and 8.5 with a minimal, behaviour-preserving diff (the curl transport is otherwise untouched).
PHP 8.4 — implicit nullable parameters
Parameters typed
string $x = nullare implicitly nullable, which is deprecated in PHP 8.4. Added an explicit?to all affected signatures:EndMeetingParameters::__construct()IsMeetingRunningParameters::__construct()DeleteRecordingsParameters::__construct()UpdateRecordingsParameters::__construct()InsertDocumentParameters::__construct()GetRecordingTextTracksParameters::__construct()PutRecordingTextTrackParameters::__construct()DocumentableTrait::addPresentation()($attributes)PHP 8.5 — curl_close()
curl_close()is deprecated as of PHP 8.5 (it has had no effect since PHP 8.0, where the curl handle became aCurlHandleobject freed by the garbage collector). Removed the call insendRequest().Bonus: presentation serialization fixes
While adding
?toaddPresentation()I noticedgetPresentationsAsXML()was broken for presentations added without attributes/content (the existingtests/Parameterscases for URL/file presentations errored):null->getAttributes()fatal when noDocumentOptionsStorewas passed → now guarded.<document url="...">1</document>, because!$content ?: base64_encode($content)yieldstruefornullcontent → now stored asnull.These two one-liners turn the previously red
tests/Parameterspresentation tests green. Happy to split them into a separate PR if preferred.Verification
php -lclean on all files (PHP 8.5)tests/Parameters+tests/Responses: 18/18 green