Repository navigation
fix(BBBCheckbox): show the brand color when checked or indeterminate - #121
Open
germanocaumo wants to merge 1 commit into
Open
germanocaumo wants to merge 1 commit into
germanocaumo wants to merge 1 commit into
Conversation
The color rule, `&.Mui-checked`, is exactly as specific as MUI's own checked/indeterminate rule, so whichever stylesheet comes later wins. In BigBlueButton, MUI's emotion styles are injected after the styled-components sheet, so a checked box shows MUI's default blue (#1976d2) instead of colorBrand1. The indeterminate state was never styled, so it always showed MUI's blue. Double the class so the brand color wins in either order, and apply it to the indeterminate state too. A disabled box now always shows MUI's disabled color; where the library's rule used to win, a disabled checked box was brand-colored.
germanocaumo
added a commit
to germanocaumo/bigbluebutton
that referenced
this pull request
Nov 13, 2026
The camera settings' "Whole image" brightness option was the last user of common/checkbox, and common/radio has no users. They were also the only code importing @mui/system directly, which kept a 5.x copy at the top level next to the 6.x one @mui/material uses. - The option is a BBBCheckbox. Its label names the input, and its description stays linked through aria-describedby. - common/checkbox and common/radio are removed. - @mui/system is dropped from package.json, so only MUI 6.x remains. Visible differences, both from the library's look: - the checked box is blue instead of green. It is MUI's default blue, not the brand color, until the client moves to a library release with bigbluebutton/bbb-ui-components-react#121; - the box loses MUI's 9px ripple padding (39px to 21px). The label stays clickable. The old checkbox also toggled on Enter. Like a native checkbox, it now toggles on Space.
Arthurk12
self-requested a review
November 13, 2026 23:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A checked or indeterminate
BBBCheckboxnow shows the brand color (colorBrand1) instead of MUI's default blue.&&.Mui-checked), so it wins over MUI's own rule whichever stylesheet is injected later.Closes Issue(s)
None. Found in bigbluebutton/bigbluebutton#26048.
Motivation
&.Mui-checkedis exactly as specific as MUI's.css-….Mui-checkedrule, so the stylesheet injected later wins. In the BigBlueButton client, MUI's emotion styles come after the styled-components sheet, so a checked box renders#1976d2.More
rgb(25, 118, 210)today,rgb(15, 112, 215)(#0F70D7) with this PR;rgba(0, 0, 0, 0.26).&&.Mui-checkedinstyled(BBBCheckbox)orsx), since MUI'scolorprop and a single-class override no longer win.