Skip to content

Support pyopenms 3.6 API - #86

Merged
ypriverol merged 1 commit into
devfrom
fix/pyopenms-3.6
Oct 9, 2026
Merged

ypriverol merged 1 commit into
devfrom
fix/pyopenms-3.6

Conversation

@ypriverol

Copy link
Copy Markdown
Contributor

pyopenms 3.6.0 (nanobind bindings) breaks CI on #85:

  • PeakPickerHiRes.pickExperiment now returns the picked experiment instead of filling an output argument → ms1_feature_finder fails.
  • getMetaValue("spectra_data") returns str instead of bytes → .decode fails in psm_conversion.

Both call sites now handle old and new APIs. Tested locally on pyopenms 3.5.0 (38 passed); this PR's CI covers 3.6.0.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e65d59be-72c0-4b6e-a345-b44ecfed477c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Documentation 1 minor

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ypriverol
ypriverol merged commit 425a8ff into dev Oct 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant