Skip to content

chore: clarify server URL environment variables - #19

Merged
alexanderbsingh merged 2 commits into
mainfrom
server-url-env-vars
Aug 27, 2026
Merged

chore: clarify server URL environment variables#19
alexanderbsingh merged 2 commits into
mainfrom
server-url-env-vars

Conversation

@alexanderbsingh

@alexanderbsingh alexanderbsingh commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
  • Clarify that --server-url supports SERVER_URL and BIFROST_SERVER_URL environment variables
  • Also fixes a inconsistency where the environment variables took precedence over an explicitly set flag

This comment was marked as resolved.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

internal/bifrost/options.go:69

  • url.Parse will return a nil error for many invalid values (e.g. "example.com" without a scheme/host, or an explicitly passed empty string like --server-url=). With the new env-var precedence logic, an explicitly-set empty/invalid flag value will no longer be overridden by env vars and can make the CLI fail later with a less clear error. Consider validating that the parsed URL has a scheme and host (and rejecting empty) here to fail fast with a clear message.
		}
	}
	_, err := url.Parse(opts.ServerURL)
	if err != nil {
		return err

@alexanderbsingh
alexanderbsingh marked this pull request as ready for review August 27, 2026 13:58
@alexanderbsingh alexanderbsingh self-assigned this Aug 27, 2026
@alexanderbsingh
alexanderbsingh merged commit 6216464 into main Aug 27, 2026
2 checks passed
@alexanderbsingh
alexanderbsingh deleted the server-url-env-vars branch August 27, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants