chore: clarify server URL environment variables - #19
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
internal/bifrost/options.go:69
url.Parsewill return a nil error for many invalid values (e.g. "example.com" without a scheme/host, or an explicitly passed empty string like--server-url=). With the new env-var precedence logic, an explicitly-set empty/invalid flag value will no longer be overridden by env vars and can make the CLI fail later with a less clear error. Consider validating that the parsed URL has a scheme and host (and rejecting empty) here to fail fast with a clear message.
}
}
_, err := url.Parse(opts.ServerURL)
if err != nil {
return err
konrader
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--server-urlsupportsSERVER_URLandBIFROST_SERVER_URLenvironment variables