feat: add configurable HTTP timeout for uploads - #17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Suppressed comments (2)
internal/bifrost/sbom_upload.go:173
- On context cancellation, this returns immediately but does not actually stop the background io.Copy; the goroutine can remain blocked reading from stdin (and may keep running after the temp file is closed). This can leak goroutines and keep consuming stdin data in non-terminating contexts (e.g., unit tests or if this code is reused outside the top-level CLI).
select {
case err := <-done:
return err
case <-ctx.Done():
return ctx.Err()
internal/bifrost/sbom_upload.go:161
- This comment currently assumes cancellation only happens during process termination, but this helper is also used in unit tests and may be reused in other contexts. Updating the doc comment to match the actual behavior (and the cancellation strategy) will prevent confusion.
// copyStdinWithContext copies stdin into destination and returns promptly when
// ctx is cancelled. ctx is the process signal context (Ctrl+C or SIGTERM), so a
// cancelled copy always means the process is terminating; the io.Copy goroutine
// outlives cancellation only until the process exits moments later.
# Conflicts: # internal/bifrost/cli.go
# Conflicts: # internal/bifrost/options.go
alexanderbsingh
marked this pull request as ready for review
August 7, 2026 06:53
konrader
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--http-timeoutoption for SBOM uploads