Fix Android IME rollover and stabilize deferred theme E2E - #211
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes
Deferred theme assertion
The test waited for the stored paper theme but immediately inspected the deferred background image. On a busy runner,
requestIdleCallbackhad not yet addeddata-theme-background-ready, so the assertion saw the intended temporarynonevalue. The failure trace showed the background request succeeding immediately after the assertion failed.Android IME rollover
Some Android IMEs can emit an
insertTextinput event before akeydownwith key code 229 and without composition events. xterm then schedules its own textarea-diff fallback and can replay stale text, producing duplicated or truncated terminal input. The guard now observes that ordering before xterm capture handling and suppresses only the paired fallback keydown.Testing
theme-system.spec.js: 6 passedgit diff --checkValidation boundary
The Android regression is covered through the real xterm browser integration in Chromium. It has not yet been verified on a physical OnePlus Pad 3 running Android 16 and Brave.
Failure reference: https://github.com/bifrost0x/webssh/actions/runs/34197698324
Fixes #210