Skip to content

Fix pane launcher and channel capacity diagnostics - #207

Merged
bifrost0x merged 4 commits into
mainfrom
fix/discussions-205-206-feedback
Sep 8, 2026
Merged

Fix pane launcher and channel capacity diagnostics#207
bifrost0x merged 4 commits into
mainfrom
fix/discussions-205-206-feedback

Conversation

@bifrost0x

@bifrost0x bifrost0x commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • make the terminal action-bar + open a pane-scoped launcher with saved hosts and Quick Connect
  • stage replacement connections without disconnecting or unassigning the current SSH session
  • preserve buffered terminal output plus the Files path and selection while a replacement is chosen
  • make pending connections keyboard-cancellable and correlate connect, error, banner, cancel, and late-cleanup events to the exact request
  • acknowledge cancellation only before the first irreversible step; if completion wins, retain the request correlation, keep the committed connection active, and explain the too-late cancellation
  • reactivate and focus the preserved session immediately when a replacement dialog is dismissed, including after connection failure or a too-late cancellation
  • bound cancellation acknowledgement waits to five seconds, keep the pending action retryable, and recover cleanly when an accepted cancellation acknowledgement was lost
  • preserve existing tmux sessions on cancelled reconnects while deleting and killing only newly created cancelled tmux sessions
  • classify SSH channel-open code 4 as temporary remote resource shortage, keep Files usable, and retry SFTP and diagnostics every 60 seconds until recovery
  • keep layered Escape behavior predictable across Files, mobile More, the command palette, Broadcast, and tab rename

No saved connection, live SSH session, tmux reconnect candidate, terminal output, or Files context is intentionally removed by this change.

Implements the requests from Discussions #205 and #206.

Validation

  • full Python suite: 2,788 passed, 29 skipped
  • JavaScript unit suite: 40/40 test files passed
  • i18n parity suite: 15 passed
  • full Playwright suite: 119/119 passed across two shards
  • focused cancellation and replacement Playwright coverage: 3/3 passed
  • ESLint over static/js: passed
  • git diff --check: passed
  • independent backend and user-flow audits: no remaining release blocker

The final local validation used mocked SSH/tmux peers rather than a physical remote SSH host; GitHub CI runs separately on the exact pushed commit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T06:53:28.769971Z 3aada45 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a4041ff2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/app.js Outdated
@bifrost0x
bifrost0x force-pushed the fix/discussions-205-206-feedback branch from 1a4041f to 7d33edd Compare September 7, 2026 18:07
@bifrost0x

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d33eddf75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/session_insights.py Outdated
@bifrost0x
bifrost0x force-pushed the fix/discussions-205-206-feedback branch from 7d33edd to 5552371 Compare September 7, 2026 19:33
@bifrost0x bifrost0x changed the title Fix pane launcher and unsupported channel diagnostics Fix pane launcher and channel capacity diagnostics Sep 7, 2026
@bifrost0x

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55523718b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/sftp_handler.py Outdated
@bifrost0x
bifrost0x force-pushed the fix/discussions-205-206-feedback branch from 5552371 to a7b9acf Compare September 7, 2026 19:51
@bifrost0x

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: a7b9acf9eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Keep live sessions and file context intact while choosing a replacement, make cancellation request-safe and honest around startup commands, and treat remote channel capacity as retryable. Tighten keyboard, focus, mobile, tmux, and late-result cleanup behavior with regression coverage.
@bifrost0x

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f81c79c517

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/app.js Outdated
@bifrost0x

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b514387b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/app.js
@bifrost0x

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 3aada45355

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@bifrost0x
bifrost0x merged commit cebedbe into main Sep 8, 2026
20 of 21 checks passed
@bifrost0x
bifrost0x deleted the fix/discussions-205-206-feedback branch September 8, 2026 06:55
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant