Skip to content

Decode and preserve BOM-marked UTF-16 text files - #232

Draft
github-actions[bot] wants to merge 2 commits into
mainfrom
agent/issue-230-31103119921-1
Draft

Decode and preserve BOM-marked UTF-16 text files#232
github-actions[bot] wants to merge 2 commits into
mainfrom
agent/issue-230-31103119921-1

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

Decode BOM-marked UTF-16LE and UTF-16BE text files for editor reads and content search. Preserve the existing BOM and byte order when saving edits; keep UTF-8 behavior unchanged.

Closes #230

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update

Testing

  • Existing tests pass
  • Added new tests for changes
  • Tested manually (describe below)

Manual Testing Details:

  • pnpm --filter @hubble.md/desktop exec vitest run electron/textFile.test.ts — 3 tests passed
  • pnpm --filter @hubble.md/desktop test — 185 tests passed
  • pnpm build:desktop — passed
  • pnpm exec biome check apps/desktop/electron/textFile.ts apps/desktop/electron/textFile.test.ts apps/desktop/electron/main.ts — passed
  • Real Electron/CDP verification was attempted with HUBBLE_DESKTOP_ENABLE_CDP=1 pnpm dev:desktop, but Electron could not launch because the container's SUID sandbox helper is not configured with root ownership and mode 4755.

Checklist

  • I discussed this change in a GitHub issue before submitting this PR
  • I have run the linter, formatter, and tests to ensure my code is ready for review

Implemented by a Warp Factory agent.

Co-Authored-By: Warp Factory Agent <oz-agent@warp.dev>
Co-Authored-By: Warp Factory Agent <oz-agent@warp.dev>
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hubble-md-web Ready Ready Preview Aug 6, 2026 12:56pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decode and preserve BOM-marked UTF-16 text files

1 participant