feat: add bgpkit-parser v0.19 extended filters, remove unused deps - #148
Merged
Conversation
Add nine extended element filters from bgpkit-parser v0.19 to ParseFilters, monocle search, monocle parse, and the SSE search API: --otc, --next-hop, --origin, --local-pref, --med, --atomic-aggregate, --aggr-asn, --aggr-ip, --peer-bgp-id. Optional-attribute filters support * (present) and !* (absent) presence wildcards. Remove unused radar-rs dependency (Cloudflare Radar API support was removed during the lens refactor but the Cargo.toml entry survived). Fix bgpkit-parser dev-dependency version conflict ([dev-dependencies] pinned v0.18.0 while main dep uses v0.19.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monocle search,monocle parse, and the SSE search API:--otc,--next-hop,--origin,--local-pref,--med,--atomic-aggregate,--aggr-asn,--aggr-ip,--peer-bgp-id. Optional-attribute filters support*(present) and!*(absent) presence wildcards.radar-rsdependency (Cloudflare Radar API support was removed during the lens refactor but the Cargo.toml entry survived).bgpkit-parserdev-dependency version conflict:[dev-dependencies]pinned v0.18.0 while the main dependency uses v0.19.0, causingE0464: multiple candidates for rliboncargo test --all-features.Changes
Cargo.tomlradar-rs, remove dev-depbgpkit-parser = "0.18.0"src/lens/parse/mod.rsParseFiltersfields +validate_extended_filters()+ 3 unit testssrc/server/search.rsSearchStreamFiltersSSE DTOsrc/lens/search/mod.rs..Default::default()src/lens/mod.rsCHANGELOG.mdTest plan
cargo build— cleancargo clippy --all-features -- -D warnings— cleancargo fmt --check— cleancargo test --lib— 296 passed, 0 failedcargo test --lib(filter tests) — 5/5 passed, including 3 new tests for extended filter validation and parser wiringmonocle search --helpandmonocle parse --helpradar-rsabsent fromcargo treebgpkit-parserentry inCargo.lock