fix(infra): core-api's values-local still told readers to use a URL that does not work - #431
Merged
Merged
Conversation
…hat does not work `host.docker.internal:30080` fails inside a kind pod with `Could not resolve host` — the pod resolves through CoreDNS in the node and never sees the Docker Desktop entry. That was measured on 2026-08-04 and corrected in `kind/core-cluster.yaml` and `local-test.sh`. This file was missed, and it is the worst one to miss: its comment is where a reader looks up what to configure the Tracker with. The other two charts carry the right URL because they were written after the correction. Only core-api, written before it, kept the wrong one. Corrected to `http://<cluster>-control-plane:30080` with the reason attached, since the wrong URL is the plausible one and someone will reach for it again. Also answers a question this file raised rather than registering it as a gap: `up`/`apps-up` target Docker Desktop's built-in Kubernetes, inherit these NodePort values, and were never exercised — this machine has no `docker-desktop` context, so they cannot be exercised here. Left alone deliberately and the reason written down: Docker Desktop publishes node ports on localhost itself, needing no kind config, and a pinned node port either works or fails the install with a port conflict. There is no silent-wrong mode to protect against, so there is nothing to guess at. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
host.docker.internal:30080fails inside a kind pod withCould not resolve host— the pod resolves through CoreDNS in the node and never sees the Docker Desktop entry. That was measured on 2026-08-04 and corrected inkind/core-cluster.yamlandlocal-test.sh.This file was missed, and it is the worst one to miss: its comment is where a reader looks up what to configure the Tracker with.
The other two charts carry the right URL because they were written after the correction. Only
core-api, written before it, kept the wrong one.Corrected to
http://<cluster>-control-plane:30080with the reason attached, since the wrong URL is the plausible one and someone will reach for it again.It also answers a question instead of registering it
up/apps-uptarget Docker Desktop's built-in Kubernetes, inherit these NodePort values, and were never exercised. Rather than filing that as a gap, it was measured:docker-desktopcontext, so the path cannot be exercised here.core-cluster.yamlrequirement is kind-only and the comment now says so.So there was nothing to register: there was a note to write and an error to fix. Both are here, with the reasoning, instead of a card saying "pending verification".
grep host.docker.internaloutside the notes explaining ithelm templatewith these valuesci-runner.mjs governance🤖 Generated with Claude Code