Repository navigation
Protect first use and gate releases on real browser journeys - #16
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First use could load an unused temporary world, graphics failures could take editing down, and early numeric input or deferred focus could be lost. Graphics now start after the welcome/restore decision; a DOM process fallback preserves editing, calculation and template saves if WebGL or the graphics module fails. Numeric initialization, stable scene dimensions, scoped keyboard focus, skip links and an initially visible mobile action improve reliability. Static PNG cards prefer CPU-backed offscreen encoding, retaining the original five-second deadline and bounded HTML fallback.
Four isolated browser jobs run in parallel. The final required check keeps the existing
verifyname and explicitly requires source checks plus every browser matrix job to succeed. Pages deployment also waits for all four jobs, built from the same source and configured public base; no additional build-artifact storage is introduced. CI selects the existing Low power view through the real UI and asserts unchanged numerical identity; every model, result, focus and persistence assertion remains active. Detailed rendering is separately verified locally.Local private folders and overrides are blocked from dev HTTP delivery and generated-file reloads while preserving Vite’s standard secret blocklist. Existing engine definitions, sampling, project data and storage formats are unchanged. README guided entry, current changelog, first-contribution/feedback paths and a PR template improve contributor entry; local documentation links and common heading anchors are checked automatically.
Local validation: 457 unit tests; 3 documentation tests; preview ownership, dev HTTP and unknown-suite checks; typecheck, production build, headless contracts, 1,141 assets and template/demo exports pass. Built browser journeys cover 8 first-use groups, 6 cold-start/recovery/entry groups, 7 template groups and 18 original-world checks, with zero page errors. The legacy quality phase passes 4 checks/7 files without relaxing the scene-geometry assertion. Private-file HTTP requests return 403 and private HTML writes do not reload the app. PNG fast/fallback paths and the unchanged deadline have regression tests.
Actual Linux CI additionally caught colored-preview detection, slow-render focus timing and PNG encoding starvation; fixes preserve assertions and time limits. Real first-time participant studies and physical-device testing are not claimed.