fix: six.moves.reload_module uses imp.reload in Python 2 (#158)#404
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
fix: six.moves.reload_module uses imp.reload in Python 2 (#158)#404fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
…recationWarning (benjaminp#158) reload() in Python 2 emits DeprecationWarning when run with -3 flag. Changing the source from __builtin__ (built-in reload) to imp.reload eliminates the warning since imp.reload is the preferred way to reload in Python 2. Fixes benjaminp#158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: DeprecationWarning from reload_module in Python 2 -3 mode
reload()in Python 2 emitsDeprecationWarningwhen run with-3flagbecause
reloadis removed in Python 3. Changed the source from__builtin__.reloadtoimp.reloadwhich is the preferred API anddoes not trigger the warning.
Python 3 paths are unaffected (already use
importlib.reload/imp.reload).Fixes #158
Support my work: If this fix helped, consider buying me a coffee at https://buymeacoffee.com/muhamedfazalps ☕