Skip to content

chore: migrate to using embd - #48

Merged
ptsouchlos merged 4 commits into
mainfrom
PT/use-embd
Nov 17, 2026
Merged

ptsouchlos merged 4 commits into
mainfrom
PT/use-embd

Conversation

@ptsouchlos

Copy link
Copy Markdown
Member

Move to using embd for infra, checked out to the same commit, but tracking main.

@coveralls

coveralls commented Nov 16, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — PT/use-embd into main

@ednolan ednolan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start.

The next step is handling CI.

Currently the repo has a beman-submodule unit test:

https://github.com/bemanproject/transform_view/actions/runs/43874209273/job/133322888058

It passes for this pull request because, since we removed the .beman-submodule file, the beman-submodule CI says "okay, all zero of the beman-submodules in this repository are consistent."

My understanding of the way that CI is intended to work for embd is that embd will have a pre-commit check.

We already check that pre-commit passes in CI: https://github.com/bemanproject/transform_view/blob/83b748a59c213610a8542cb82d07b6ad6bc0472c/.github/workflows/pre-commit-check.yml

So what we need to do for this commit is:

  • Add a pre-commit check for embd to transform_view/.pre-commit-config.yaml
  • Update transform_view/.github/workflows/ci_tests.yml to delete the following lines:
  beman-submodule-check:
    uses: bemanproject/infra-workflows/.github/workflows/reusable-beman-submodule-check.yml@1.7.4

@ptsouchlos
ptsouchlos requested a review from ednolan November 16, 2026 14:59
@ptsouchlos

Copy link
Copy Markdown
Member Author

This is a good start.

The next step is handling CI.

Currently the repo has a beman-submodule unit test:

https://github.com/bemanproject/transform_view/actions/runs/43874209273/job/133322888058

It passes for this pull request because, since we removed the .beman-submodule file, the beman-submodule CI says "okay, all zero of the beman-submodules in this repository are consistent."

My understanding of the way that CI is intended to work for embd is that embd will have a pre-commit check.

We already check that pre-commit passes in CI: https://github.com/bemanproject/transform_view/blob/83b748a59c213610a8542cb82d07b6ad6bc0472c/.github/workflows/pre-commit-check.yml

So what we need to do for this commit is:

* Add a pre-commit check for embd to transform_view/.pre-commit-config.yaml

* Update transform_view/.github/workflows/ci_tests.yml to delete the following lines:
  beman-submodule-check:
    uses: bemanproject/infra-workflows/.github/workflows/reusable-beman-submodule-check.yml@1.7.4

Thanks for the feedback @ednolan , I've made the requested changes. Let me know if there's anything I missed.

@ednolan ednolan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@ptsouchlos
ptsouchlos requested a review from ednolan November 16, 2026 16:40
@ptsouchlos

ptsouchlos commented Nov 16, 2026 •

Copy link
Copy Markdown
Member Author

@ednolan Lmk how you want to handle the failing tests

@ptsouchlos
ptsouchlos merged commit b2af7fc into main Nov 17, 2026
129 of 130 checks passed
@ptsouchlos
ptsouchlos deleted the PT/use-embd branch November 17, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants