Repository navigation
chore: migrate to using embd - #48
Conversation
ednolan
left a comment
There was a problem hiding this comment.
This is a good start.
The next step is handling CI.
Currently the repo has a beman-submodule unit test:
https://github.com/bemanproject/transform_view/actions/runs/43874209273/job/133322888058
It passes for this pull request because, since we removed the .beman-submodule file, the beman-submodule CI says "okay, all zero of the beman-submodules in this repository are consistent."
My understanding of the way that CI is intended to work for embd is that embd will have a pre-commit check.
We already check that pre-commit passes in CI: https://github.com/bemanproject/transform_view/blob/83b748a59c213610a8542cb82d07b6ad6bc0472c/.github/workflows/pre-commit-check.yml
So what we need to do for this commit is:
- Add a pre-commit check for embd to transform_view/.pre-commit-config.yaml
- Update transform_view/.github/workflows/ci_tests.yml to delete the following lines:
beman-submodule-check:
uses: bemanproject/infra-workflows/.github/workflows/reusable-beman-submodule-check.yml@1.7.4
Thanks for the feedback @ednolan , I've made the requested changes. Let me know if there's anything I missed. |
|
@ednolan Lmk how you want to handle the failing tests |
Checked out to the same commit but tracking `main`.
9069bfd to
dafd9c3
Compare
Move to using
embdfor infra, checked out to the same commit, but trackingmain.