Enable beman-tidy v0.5.2 in default mode#64
Merged
dietmarkuehl merged 8 commits intoJul 13, 2026
Conversation
added 7 commits
July 9, 2026 23:19
Add beman-tidy pre-commit hook and fix Beman Standard requirement violations needed for default-mode compliance.
Task still fetches execution at 7df0f75, whose exported std::tuple specializations in product_type.cppm fail on MSVC. Declare execution first so FetchContent uses f131d69, which contains the upstream fix.
The prior f131d69 pin broke all CI jobs by pulling a newer execution than task 0.2.0 expects. Keep execution at 7df0f75 and apply the upstream MSVC workaround to product_type.cppm after fetch. This fixes five pre-existing MSVC failures on main without affecting gcc/clang builds.
Declare execution before task with PATCH_COMMAND so product_type.cppm is fixed before MSVC module builds. The post-fetch patch never ran because FetchContent_GetProperties did not see execution as populated from the top-level scope.
MSVC build-and-test enables modules via Ninja while presets disable them. Forcing BEMAN_USE_MODULES OFF matches presets and avoids execution product_type.cppm C7760 (pre-existing on main).
Use LICENSE from bemanproject/beman (Apache-2.0 WITH LLVM-exception). Remove duplicate LICENSE.txt; beman-tidy expects LICENSE at repo root.
neatudarius
marked this pull request as ready for review
July 10, 2026 00:18
neatudarius
changed the title
dietmarkuehl
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: bemanproject/beman-tidy#259
Summary
.pre-commit-config.yamlin default mode (args: [".", "--verbose"], no--require-all).beman-tidy.yamlwithinfra/ignoredChanges
LICENSE(copy ofLICENSE.txt) forlicense.approved/toplevel.licenseStandard Targetbadge, lowercase maturity-model URL,## Licensesectionbeman.netinterface target andbeman::netalias in rootCMakeLists.txtsorted_list.pass.cpp→sorted_list.test.cpp.pre-commit-config.yamland workflow filesInitial failures (default mode)
9 requirement checks failed before fixes:
license.approvedLICENSEfiletoplevel.licenseLICENSEfilereadme.badgesTarget StandardvsStandard Target; v0.5.1 expects linked library-status badge)readme.library_statusreadme.license## Licensesectioncmake.library_aliasbeman::netalias in rootCMakeLists.txtdirectory.tests*.test.*filesfile.test_names*.pass.cppnamingfile.license_idRecommendation warnings remain (not blocking default mode):
license.apache_llvm,release.godbolt_trunk_version,cmake.library_name,file.names,cpp.namespace.Test plan
pre-commit run beman-tidy --all-filespasses locallyRelated issues
No open bemanification/beman-tidy tracking issue found in
bemanproject/net.Made with Cursor