Skip to content

Remove default member initializer of prop - #345

Merged
dietmarkuehl merged 1 commit into
bemanproject:mainfrom
Cra3z:fix-prop
Nov 18, 2026
Merged

dietmarkuehl merged 1 commit into
bemanproject:mainfrom
Cra3z:fix-prop

Conversation

@Cra3z

@Cra3z Cra3z commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

When building with clang + libstdc++, I found that some examples and tests in beman.execution fail to compile, e.g. sleep_sort.cpp and dis-task_scheduler-allocation.test.cpp. The Value type of prop there is task_scheduler and the allocator at dis-task_scheduler-allocation.test.cpp:114, respectively. They have one thing in common: neither is default constructible. So I suspected the default member initializers in prop were the cause, and removing them does make the build succeed.

I came up with a minimal reproduction: https://godbolt.org/z/33reo1jz9

In short, using default member initializers makes something no longer SFINAE-friendly, which leads to unexpected hard errors.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 92.722%. remained the same — Cra3z:fix-prop into bemanproject:main

@dietmarkuehl
dietmarkuehl merged commit c00e229 into bemanproject:main Nov 18, 2026
81 of 82 checks passed
@Cra3z
Cra3z deleted the fix-prop branch November 19, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants