Repository navigation
Remove default member initializer of prop - #345
Merged
Merged
Conversation
dietmarkuehl
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with clang + libstdc++, I found that some examples and tests in beman.execution fail to compile, e.g.
sleep_sort.cppanddis-task_scheduler-allocation.test.cpp. TheValuetype ofpropthere istask_schedulerand theallocatoratdis-task_scheduler-allocation.test.cpp:114, respectively. They have one thing in common: neither is default constructible. So I suspected the default member initializers inpropwere the cause, and removing them does make the build succeed.I came up with a minimal reproduction: https://godbolt.org/z/33reo1jz9
In short, using default member initializers makes something no longer SFINAE-friendly, which leads to unexpected hard errors.