Skip to content

Allow beman::execution to work with exceptions and RTTI disabled - #342

Merged
dietmarkuehl merged 4 commits into
bemanproject:mainfrom
Cra3z:no-exception-and-rtti
Nov 18, 2026
Merged

dietmarkuehl merged 4 commits into
bemanproject:mainfrom
Cra3z:no-exception-and-rtti

Conversation

@Cra3z

@Cra3z Cra3z commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

In practice, many C++ projects disable exceptions and RTTI, so beman::execution should take these cases into account. The changes in this PR will allow beman::execution to work even when exceptions and RTTI are disabled.

@Cra3z
Cra3z marked this pull request as draft November 17, 2026 07:54
@coveralls

coveralls commented Nov 17, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 92.992% (+0.3%) from 92.722% — Cra3z:no-exception-and-rtti into bemanproject:main

@Cra3z
Cra3z force-pushed the no-exception-and-rtti branch from 93baa3d to 359a522 Compare November 18, 2026 02:21
@Cra3z
Cra3z marked this pull request as ready for review November 18, 2026 02:56
@Cra3z

Cra3z commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

@dietmarkuehl, should we add CI tests for disabling exceptions and RTTI? I’m not quite sure how to do that.

@dietmarkuehl dietmarkuehl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! I always wanted to work towards compiling beman.execution for embedded systems and that should be a step in that direction.

To avoid code using exceptions unguarded showing up there should probably also be a test on CI verifying that things continue to build without exceptions and RTTI.

@dietmarkuehl
dietmarkuehl merged commit 4fec693 into bemanproject:main Nov 18, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants