Make PHP v6 client constructible after production install - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I installed the new PHP v6 release into a clean Composer project and found that installation succeeded, but constructing
BeeperDesktop\Clientfailed:src/Client.php:98-104asks discovery for a URI, stream, request factory, and HTTP client.composer.jsononly required the PSR interfaces; its concrete Guzzle implementation was underrequire-dev, which consumers do not install. I moved Guzzle torequireand updated the lockfile so an ordinary production install supplies the client and factories. In a fresh--no-devinstall,new Client(...)now succeeds and exposesLabelsService. I bumped the version to 6.0.1 rather than changing the already published v6.0.0 tag.Tag
@indentto continue the conversation here.