Repository navigation
test: fix the nightly e2e, add Gitea 28 - #14
Merged
Merged
Conversation
…Int in ghfake TestDoctor wanted the writer's scopes ok on any Gitea, but Gitea 1.26 has no GET /api/v1/token, so doctor rightly says unknown there. The test now asks the server's version: ok from Gitea 1.27 on, unknown with the reason before. The GitLab stand's shell runner ran the Ubuntu gitlab-runner image, whose git 2.43 is too old for plan (2.45), so TestSetup's reader job failed on every image. It now runs the Alpine image of the same version, with git 2.47 to 2.54. ghfake took a GraphQL Int as 64 bits. The GraphQL spec makes it a signed 32-bit integer, so a literal or variable out of that range now fails validation or coercion as on GitHub; this also ends four CodeQL integer-conversion alerts.
Gitea 28 refuses a team created with both units and units_map (HTTP 400), so gitea.sh and the e2e fixtures send units_map alone, which Gitea 1.26 to 28 and Forgejo 15 and 16 all take. The full suite passes on Gitea 1.26.4, 1.27.3 and 28.1.0 and Forgejo 15.0.9 and 16.0.5, and the facts the e2e records on 28.1.0 match 1.27.3's. Pull requests now run Gitea 28.1.0, the latest, and the nightly run all five images.
AlexeyShalaev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly runs of 2026-10-07 failed in two places, both in the tests:
TestDoctor. The test wanted the writer's scopesokon any Gitea, butGET /api/v1/tokenexists from Gitea 1.27 on, so on 1.26 doctor rightly reports themunknown. The test now asks the server's version:okfrom 1.27,unknownwith that reason before. Only the nightly matrix runs 1.26, so pull requests never saw it.TestSetup. The stand's shell runner ran the Ubuntugitlab/gitlab-runnerimage, whose git 2.43 is too old forplan(2.45), so the reader job failed. The stand now runs the Alpine image of the same version: git 2.47 (17.11.4), 2.52 (18.11.4), 2.54 (19.4.1).Also, ghfake took a GraphQL
Intas 64 bits. The GraphQL spec makes it a signed 32-bit integer, so a literal or variable out of range now fails validation or coercion, as on GitHub, with tests. This closes CodeQL alerts #4–#7.Checked locally:
scripts/e2e/gitea.sh --run TestDoctoron Gitea 1.26.4 and 1.27.3 passes;scripts/e2e/gitlab.sh gitlab/gitlab-ce:18.11.12-ce.0passes every test,TestSetupincluded; the ghfake tests pass.Gitea 28. Gitea 28.0.0 and 28.1.0 are out. The stand could not seed 28: it refuses a team created with both
unitsandunits_map(HTTP 400), sogitea.shand the e2e fixtures now sendunits_mapalone, which every supported version takes. The full suite passes locally on Gitea 1.26.4, 1.27.3 and 28.1.0 and Forgejo 15.0.9 and 16.0.5, and the facts the e2e records on 28.1.0 match 1.27.3's. Pull requests now run Gitea 28.1.0, the latest, and the nightly runs all five images. The docs' "Gitea 1.26 and newer" covers 28 already.