Repository navigation
feat(cli): --assume-opt-in for status and apply - #12
Merged
Merged
Conversation
A hub that subscribes repositories through an org or group entry with opt_in: assumed left local commands stuck: they cannot list the organisation, so a checkout without an opt-in file counted as not opted in, and apply --adopt refused until someone added a throwaway opt-in file. --assume-opt-in settles it locally: the target counts as opted in, as such an entry would make it, and the report says so (opt_in: flag, 'opted in by --assume-opt-in'). An opt-in file, enabled: false included, still wins, and a repo: entry that subscribes the target still reports assumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hub that subscribes repositories through an
org:orgroup:entry withopt_in: assumedleft the local commands stuck. They cannot list the organisation, so a checkout without an opt-in file counted as not opted in. Taking a file back under the hub (apply --adopt) then refused until someone added a throwaway opt-in file. That happened in the bedrock-python rollout.--assume-opt-inonstatusandapplysettles it locally: the target counts as opted in, as such an entry would make it.opt_in: flagin JSON, "opted in by --assume-opt-in" in text.enabled: falseincluded. Arepo:entry that subscribes the target still reportsassumed.opt_invalue), the command reference and the agents page.Tests cover a library the org entry may subscribe (status, golden text, apply writing the packs), a target without a name, a
repo:entry, andenabled: falsewinning over the flag.