Repository navigation
test(e2e): run the template's pipelines against a release - #10
Merged
Merged
Conversation
The Gitea and GitLab template tests replaced only the TODO(release) placeholder, whose digest is all zeros, with the image under test, so after the template pinned v0.1.0 they failed before running a job. They now replace the template's touchmark image whatever its digest, as the release checklist runs them after a release.
With Docker's containerd image store, pushing a multi-platform image that was pulled for one platform sends that platform's manifest alone, while RepoDigests keeps the index's digest. The template stands referenced the image by that digest, which the local registry lacked: GitLab's runner, which always pulls, failed every job with a published image; Gitea's found the image in the daemon and passed. template-lib.sh now asks the registry for the tag's digest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release checklist runs the template's pipelines against the published image once the template pins it (docs/project/release.md, "After a release"). With v0.1.0 that failed twice, both in the test harness:
With both, against ghcr.io/bedrock-python/touchmark@sha256:0b78f8d9… and the template pinned to v0.1.0:
gitea.sh --template … --touchmark-image … --run TestTemplate docker.gitea.com/gitea:1.27.3andgitlab.sh … gitlab/gitlab-ce:18.11.12-ce.0pass, and so does the GitHub dry run TestTemplateWorkflow.