Repository navigation
chore: test every supported Python and gate coverage in CI - #47
Merged
Merged
Conversation
- CI: run the unit tests on Python 3.10 to 3.14 (was 3.11 to 3.13), and add the 3.14 classifier. - CI: the integration job runs the whole suite with the coverage options of `make test` (90% threshold, XML report) and uploads it to Codecov, which the README badge reads. - tests: restore `redis_client_kit.providers` after the providers re-import tests. On Python 3.10 mock.patch resolved its targets through the stand-in package and three provider tests failed. - PR template: ask for a Conventional Commit title instead of a CHANGELOG.md entry, which release-please generates. - Issue template config: drop the link to Discussions, which are disabled. - Project profile: update the CI and Python 3.10 notes.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while filling in the project profile:
requires-pythonis>=3.10, but CI tested 3.11 to 3.13: it now tests 3.10 to 3.14, and the classifiers list 3.14. Python 3.10 found a real bug in a test:test_providers_init.pyre-importsredis_client_kit.providersand left the stand-in package bound on its parent, whichmock.patchon 3.10 then found. The test now restores the attribute too; 160 unit tests pass on 3.10 to 3.14;make testruns the whole suite with a 90% gate, and the README's Codecov badge had nothing behind it. The integration job, which has Docker, now runs the whole suite withmake test's options (99.6% locally) and uploadscoverage.xmlto Codecov, as deadline-budget does;CHANGELOG.mdentry under[Unreleased]: it now asks for a Conventional Commit title, as in clientwright;.agents/project.mdfollows these changes.