Pin tailscale to v1.95-pre so the module stays on go 1.25 - #1849
Closed
luke-lombardi wants to merge 1 commit into
Closed
Pin tailscale to v1.95-pre so the module stays on go 1.25#1849luke-lombardi wants to merge 1 commit into
luke-lombardi wants to merge 1 commit into
Conversation
v1.102.2 raised the go directive to 1.26.5, which the go 1.25.13 build image (GOTOOLCHAIN=local) and downstream importers cannot satisfy. Tagged releases offer no way out: everything through v1.94 pins the old gvisor netstack API (incompatible with our cross-GPU-restore gvisor), and v1.96+ requires go 1.26. Commit d58bfb8a sits in the window after tailscale bumped gvisor (matching our exact pin) and before it moved to go 1.26: go directive 1.25.7, disco fixes included. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Pushed directly to main as 74483d8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1848 bumped
tailscale.comto v1.102.2, which raised thegodirective to 1.26.5. The release build image runs go 1.25.13 withGOTOOLCHAIN=local, so builds fail:The same directive would force a toolchain bump on every downstream importer (clip, geese, etc.).
Fix
No tagged tailscale release works here: everything through v1.94 pins the old gvisor netstack API (incompatible with the cross-GPU-restore gvisor from #1846), and v1.96+ requires go 1.26. Tailscale bumped gvisor on Feb 27 and moved to go 1.26 on Mar 5, so this pins the last commit in that window (
d58bfb8a, resolves asv1.95.0-pre):go 1.25.7— satisfied by the 1.25.13 build image and downstream toolchainsgvisor.dev/gvisor v0.0.0-20260224225140— byte-identical to our existing pinModule
godirective lands at 1.25.7 (previously understated at 1.25.0; our gvisor already required ≥1.25.5).Test plan
go build ./pkg/... ./cmd/...go test ./pkg/network/ ./pkg/abstractions/pod/ ./pkg/worker/all passGOTOOLCHAIN=local) completesMade with Cursor
Summary by cubic
Pin
tailscale.comto v1.95-pre and lower the modulegodirective to 1.25.7 so builds succeed on Go 1.25.13. Previouslytailscale.com v1.102.2required Go 1.26.5 and broke release builds withGOTOOLCHAIN=local; now builds pass and downstream importers are not forced to Go 1.26. Includes disco/NAT traversal fixes without reverting the newer gVisor netstack.go 1.25.7ingo.modand pintailscale.comto v1.95-pre to stay before the Go 1.26 bump.gvisor.dev/gvisorpin unchanged; matches our existing version.github.com/creachadair/msync,github.com/go-json-experiment/json, andgithub.com/tailscale/wireguard-go; addgithub.com/prometheus-community/pro-bing.Written for commit 90dfa13. Summary will update on new commits.