Await watch shutdown and clean up failed startup - #303
Open
bcomnes wants to merge 2 commits into
Open
Conversation
This was referenced Sep 6, 2026
Coverage Report for CI Build 34011495814Coverage increased (+0.4%) to 94.828%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
bcomnes
marked this pull request as ready for review
September 6, 2026 04:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #295.
Stacked on #294 so its watch dependency tests remain part of validation.
Validation
npm testpassed outside the restricted runner: Node tests, Playwright, lint, installed-check, and TypeScript.EMFILEfailures reproduce in the restricted runner but not outside it; this PR does not claim the missing await caused them.Merge order
Merge #294 first, then retarget this draft to
masterif GitHub does not do so automatically.The conventions and watch-planner drafts follow this branch.