Skip to content

#5453 - Remove tuition remittance amount default#6338

Merged
weskubo-cgi merged 3 commits into
mainfrom
feature/#5453-remove-remittance-default
Jul 8, 2026
Merged

#5453 - Remove tuition remittance amount default#6338
weskubo-cgi merged 3 commits into
mainfrom
feature/#5453-remove-remittance-default

Conversation

@weskubo-cgi

@weskubo-cgi weskubo-cgi commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Removed Tuition remittance amount $0 default on initialization and cancel.
  • Converted to script setup.

Screenshots

image image

@weskubo-cgi weskubo-cgi self-assigned this Jul 7, 2026
Copilot AI review requested due to automatic review settings July 7, 2026 21:53
Copilot AI reviewed Jul 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Institution “Confirm enrolment” approval modal to remove the default $0 value for the “Tuition remittance amount” input, so the amount field starts empty unless the user enters a value.

Changes:

  • Removed the initial tuitionRemittanceAmount: 0 default from the modal’s reactive form model.

Comment thread sources/packages/web/src/components/institutions/modals/confirmationOfEnrollment/ApproveCOE.vue Outdated
@weskubo-cgi weskubo-cgi requested a review from Copilot July 7, 2026 22:25
Copilot AI reviewed Jul 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread sources/packages/web/src/components/institutions/modals/confirmationOfEnrollment/ApproveCOE.vue
Comment thread sources/packages/web/src/components/institutions/modals/confirmationOfEnrollment/ApproveCOE.vue
@weskubo-cgi weskubo-cgi changed the title #5453 - Removed Tuition remittance amount default #5453 - Remove tuition remittance amount default Jul 7, 2026
andrewsignori-aot
andrewsignori-aot reviewed Jul 8, 2026
View reviewed changes
Comment thread sources/packages/web/src/components/institutions/modals/confirmationOfEnrollment/ApproveCOE.vue Outdated
Comment on lines +120 to +121
confirmCOE.value.reset();
confirmCOE.value.resetValidation();

@andrewsignori-aot andrewsignori-aot Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty minor; calling both methods was necessary during Vuetify beta, where they were failing.
reset() should be enough, but I did not test it.

@weskubo-cgi weskubo-cgi Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look thanks.

@weskubo-cgi weskubo-cgi Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that reset() handles field values and validation state.

andrewsignori-aot
andrewsignori-aot approved these changes Jul 8, 2026
View reviewed changes

@andrewsignori-aot andrewsignori-aot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor, looks good 👍

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20.04% ( 4769 / 23800 )
Methods: 9.77% ( 282 / 2887 )
Lines: 24.38% ( 4077 / 16724 )
Branches: 9.79% ( 410 / 4189 )

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 47.49% ( 2753 / 5797 )
Methods: 37.27% ( 287 / 770 )
Lines: 54.3% ( 2082 / 3834 )
Branches: 32.19% ( 384 / 1193 )

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 81.25% ( 9646 / 11872 )
Methods: 80.8% ( 1250 / 1547 )
Lines: 84.53% ( 7219 / 8540 )
Branches: 65.94% ( 1177 / 1785 )

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

E2E SIMS API Coverage Report

Totals Coverage
Statements: 69.13% ( 14348 / 20756 )
Methods: 66.65% ( 1705 / 2558 )
Lines: 72.26% ( 10268 / 14210 )
Branches: 59.55% ( 2375 / 3988 )

dheepak-aot
dheepak-aot approved these changes Jul 8, 2026
View reviewed changes

@dheepak-aot dheepak-aot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Looks good. 👍

@weskubo-cgi weskubo-cgi added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 46002b8 Jul 8, 2026
22 checks passed
@weskubo-cgi weskubo-cgi deleted the feature/#5453-remove-remittance-default branch July 8, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@dheepak-aot dheepak-aot dheepak-aot approved these changes
@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@weskubo-cgi weskubo-cgi

Labels

Web portal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weskubo-cgi @dheepak-aot @andrewsignori-aot