feat(work-on-task-assistant): readiness nudge before final report

[bborbe]

Summary

• work-on-task-assistant gains Phase 7.5: a one-line readiness nudge for Obsidian tasks
• ✅ Readiness: looks execution-ready when phase != planning AND # Success Criteria exists AND has ≥1 unchecked box
• Otherwise ⚠ Readiness: <reason>. Run /vault-cli:plan-task first. — first failing check wins (phase / missing SC / all SC ticked)
• Shallow file-level check only; substance evaluation still belongs to /vault-cli:plan-task (5 hard non-negotiables + task-auditor)
• Preserves work-on-task's content-agnostic core — no questions, no edits, no blocking

Why

Current split: work-on-task = status + guides (content-agnostic by design, work-on-task.md:81); plan-task = the readiness gate. User is expected to know to run plan-task on a half-baked task — that's the friction. This change adds a cheap nudge without folding plan-task's logic into work-on-task.

Skips silently for Jira-only tasks (no local file) and recurring tasks (no Success Criteria by design).

Test plan

• make precommit clean
• Manual: invoke /vault-cli:work-on-task <half-baked-task> → see ⚠ Readiness line pointing at plan-task
• Manual: invoke /vault-cli:work-on-task <execution-ready-task> → see ✅ Readiness line
• Manual: invoke /vault-cli:work-on-task <recurring-task> → no Readiness line (silent skip)

[ben-s-pull-request-reviewer]

Based on my review of the changed files (at commit 750a1c9, which is the PR head), here is my analysis:

Review of Phase 7.5 "Readiness nudge" implementation:

1. Priority ordering (phase → SC presence → SC ticked) ✅

   • PHASE_OK correctly gates on execution/ai_review/human_review/done — planning and todo/empty are rejected first
   • SC_PRESENT checked second
   • SC_HAS_UNCHECKED checked last
   • The four distinct failure messages in priority order are correctly implemented

2. Silent skip for Jira-only and recurring tasks ✅

   • Line 208: "Skip silently for Jira-only tasks (no local Obsidian file) and for recurring tasks" — the implementation at lines 189-208 only runs within the Obsidian task block and references recurring: true check

3. SC_HAS_UNCHECKED (≥1 unchecked) ✅

   • grep -c '^\s*- \[ \]' correctly counts top-level unchecked items; nested checkboxes under a checked parent won't produce false positives since they appear as children, not siblings, of the heading

4. CHANGELOG entry ✅

   • Accurately describes the feature: shallow check, one-line nudge, no blocking/asking/editing

No issues found. The implementation matches the documented behavior.

{
  "verdict": "approve",
  "summary": "Phase 7.5 readiness nudge is correctly implemented with proper priority ordering (phase → SC presence → SC ticked), correct silent-skip logic for Jira-only and recurring tasks, and accurate SC_HAS_UNCHECKED counting. CHANGELOG entry accurately describes the feature.",
  "comments": [],
  "concerns_addressed": [
    "correctness: Phase 7.5 first-failing-check ordering matches documented priority — phase gate checked first, then SC presence, then SC ticked state",
    "correctness: Silent skip for Jira-only tasks (no local file) and recurring tasks is correctly implemented per line 208",
    "correctness: SC_HAS_UNCHECKED counts ≥1 unchecked checkbox correctly — grep pattern catches unchecked items under the heading",
    "tests: Manual verification items noted — automated testing not applicable for agent prompt changes"
  ]
}