Implement project-ignores for the project.el backend#2013
Merged
Conversation
Projectile already provided project-root, project-files, project-name and project-buffers, but project.el's protocol also expects project-ignores. Without it, tools that consult the backend for ignore globs (e.g. project-find-regexp) fell back to project.el's generic defaults and missed Projectile's own ignore configuration. Translate Projectile's globally ignored directories and file suffixes, the globally ignored files, and the dirconfig (.projectile) ignore entries into the glob format project.el documents: global names match at any depth, dirconfig paths are rooted with a leading "./".
bbatsov
force-pushed
the
feature/project-el-ignores
branch
from
0ba8bf3 to
7a10b13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projectile already implements
project-root,project-files,project-nameandproject-buffers, but project.el's protocol also expectsproject-ignores. Without it, tools that consult the backend for ignore globs (likeproject-find-regexp) fell back to project.el's generic defaults and never saw Projectile's own ignore configuration.This adds the method, translating Projectile's global ignores, ignored file suffixes, and dirconfig (
.projectile) ignore entries into the glob format project.el documents (global names match at any depth, dirconfig paths rooted with a leading./). That's the last real gap in the backend protocol -project-rootsis obsolete andproject-external-rootshas no Projectile equivalent.