Add script for programatically updating images - #2835
Open
ted-xie wants to merge 2 commits into
Open
Conversation
ted-xie
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
September 1, 2026 18:03
* Adds sentinel values in bazelci.py around the images dict for simplicity * To run: `python3 update_image_hashes.py`
ted-xie
force-pushed
the
hash-update-script
branch
from
September 2, 2026 16:06
7ecc533 to
755a498
Compare
fweikert
reviewed
Sep 2, 2026
meteorcloudy
reviewed
Sep 3, 2026
| prefix = "bazel-public/testing" if branch == "testing" else "bazel-public" | ||
|
|
||
| print(f"Detected branch: {branch}") | ||
| print(f"Default Docker registry prefix: gcr.io/{prefix}") |
Member
There was a problem hiding this comment.
I wonder do we still need gcr.io/bazel-public/testing? We can just always build from the master branch, then run this script to update bazelci.py, then the ci smoke test will test the new images?
Previously, we had to build on the testing branch and push new images to gcr.io/bazel-public/testing and make sure we use those in bazel-testing org, then rebuild those images after the Dockerfile changes are merged into master. Probably this process is no longer needed?
Contributor
Author
There was a problem hiding this comment.
I think we should still keep the testing org around for a while. The smoke test (AFAIK) doesn't cover terraform changes, while the testing org does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python3 update_image_hashes.py