dedup parallel download of the same file - #31039
Open
scaiper wants to merge 2 commits into
Open
Conversation
fmeum
reviewed
Sep 8, 2026
|
|
||
| // Downloads of identical content requested concurrently (e.g. two repos with the same URL) are | ||
| // coalesced so that only the first one transfers bytes; the rest copy the resulting file. | ||
| private final ConcurrentHashMap<String, CompletableFuture<Path>> inFlightDownloads = |
Collaborator
There was a problem hiding this comment.
Please use TaskDeduplicator instead as it correctly handles cancelation
Author
There was a problem hiding this comment.
Changed the code to use TaskDeduplicator. There are quite a bit of changes, but it's mostly moved lines.
scaiper
marked this pull request as ready for review
September 8, 2026 13:18
github-actions
Bot
added
team-ExternalDeps
Collaborator
Author
|
Sure, sounds good. Let me know when it’s ready—or feel free to make the changes directly in my PR if that’s easier. |
meteorcloudy
self-requested a review
September 9, 2026 15:09
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Concurrent fetches of the same file are deduplicated: one downloads, while other fetches wait and copy the resulting file.
Motivation
fixes #12420
Build API Changes
No
Checklist
Release Notes
RELNOTES: Concurrent fetches of identical files are now deduplicated so that the file is downloaded only once.