Skip to content

fix: add permissions for job 'ossf-scorecard' in called workflow - #96

Merged
martin-schulze-vireso merged 1 commit into
bats-core:mainfrom
bats-hardened:upstream-PR/01-add-test-permissions
Oct 14, 2026
Merged

martin-schulze-vireso merged 1 commit into
bats-core:mainfrom
bats-hardened:upstream-PR/01-add-test-permissions

Conversation

@Wuodan

@Wuodan Wuodan commented Sep 6, 2026

Copy link
Copy Markdown

This adds the permisisons needed for the test to run.

Reason:

Currently the test workflow fails instantly with:

 Invalid workflow file: .github/workflows/test.yml#L8
The workflow is not valid. .github/workflows/test.yml (Line: 8, Col: 3): Error calling workflow 'bats-core/.github/.github/workflows/test.yml@v1'. The nested job 'ossf-scorecard' is requesting 'security-events: write, id-token: write', but is only allowed 'security-events: none, id-token: none'.

The current bats-core/.github/.github/workflows/test.yml@v1 runs tag v1.1.0 in bats-core/.github where the job ossf-scorecard needs extra permissions, see bats-core/.github/.github/workflows/test.yml:56

@martin-schulze-vireso
martin-schulze-vireso merged commit 48b8731 into bats-core:main Oct 14, 2026
@martin-schulze-vireso

Copy link
Copy Markdown
Member

Thanks for your fix. I wonder why we did not catch this in the PR that introduced this change.

@Wuodan
Wuodan deleted the upstream-PR/01-add-test-permissions branch October 15, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants