sonic_ebgp: un-sickbay interface properties now that SONiC port bandwidth is modeled - #234
Merged
Merged
Conversation
…idth is modeled batfish/batfish#10231 sets SONiC port speed and bandwidth correctly. SonicValidator's interface diff now omits empty categories, so a clean comparison returns {} as the lab test expects. ---- Prompt: ``` now fix the speed thing in ~/batfish/batfish and send a PR closing the issue ``` After the Batfish fix merged: send the SonicValidator empty-diff fix together with removing the #232 sickbay entry.
dhalperi
enabled auto-merge (squash)
September 23, 2026 16:41
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 96 96
Lines 4703 4703
=======================================
Hits 3931 3931
Misses 772 772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batfish/batfish#10231 sets SONiC port speed and bandwidth correctly.
SonicValidator's interface diff now omits empty categories, so a clean
comparison returns {} as the lab test expects.
Prompt:
After the Batfish fix merged: send the SonicValidator empty-diff fix
together with removing the #232 sickbay entry.