Align submission docs with runtime defaults - #46
Merged
Conversation
Both are prose-only follow-ups to this branch's own cleanup. budget_ledger_shared_ip_spec was the last place presenting 12 + 4 + 8 as "the full commitment" without saying the 4 is BudgetHelpers' deliberately small fixture value rather than the 40 a real window derives — the same annotation the other two call sites already got here. ADR 0013's protection bullet lost its argument in the renumber: "capped at 4 rather than 40" was the claim, and "remains capped at 40" no longer supports it, since 40 is what the pre-Appendix-G remainder came to anyway. The real improvement is that core enrichment spend is now an explicit cap instead of the leftover. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SEARCH_PACING_SECONDS=0and--limit 6, matching GitHub CI so it exercises two Search batches and both payload-URL fallbacksWhy
The staged batch-enrichment merge raised
CORE_DETAIL_FALLBACK_ALLOWANCEfrom 4 to 40, but several reviewer-facing documents and comments retained the prior 4/hour and 2/2 values. The application already enforced 40/hour correctly; this PR removes the submission-level documentation contradiction and makes the local smoke test prove the full offline enrichment chain it describes.Impact
No production behavior changes. Reviewer-facing rate-limit explanations now match the runtime, and the local CI smoke gains complete deterministic enrichment coverage.
Validation
docker compose config --quietdocker compose run --rm test— 1,958 examples + 10 threaded stress examples, 0 failuresdocker compose run --rm --entrypoint bin/ci test— full fixture ingestion/enrichment smoke, queue validation, worker boot/shutdown, RuboCop, bundler-audit, and Brakeman all passeddocs/DESIGN_BRIEF.mdrendered as US Letter at 11pt/1.35 with 0.75-inch margins — exactly 2 pages; both pages visually checked for clipping and overlapgit diff --check