Add tests for AR mean forecast simulation paths#849
Open
aeshef wants to merge 1 commit into
Open
Conversation
Verify simulated mean and variance paths for AR forecasts using simulation and bootstrap methods.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 99.54% 99.53% -0.02%
==========================================
Files 78 78
Lines 15818 15886 +68
Branches 1294 1300 +6
==========================================
+ Hits 15746 15812 +66
- Misses 38 39 +1
- Partials 34 35 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading through the forecasting code, I noticed the comment with the AR mean simulation path construction was "not tested, but probably right". The added tests verify this branch directly for AR(1) and AR(2) models with GARCH volatility, covering both
method="simulation"andmethod="bootstrap".The tests recompute the simulated mean paths and long-run variance paths from the simulated residuals and residual variance paths, and compare these against the values returned by
forecast.simulations.Tested locally with: