Preserve configured senders across draft writes - #128
Conversation
There was a problem hiding this comment.
Pull request overview
Adds explicit sender preservation to draft creation, updates, sending, and reply drafts.
Changes:
- Adds
ActingSenderIDto draft content. - Adds
CreateReplyDraftWithSender. - Adds focused sender propagation tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
go/pkg/hey/messages.go |
Propagates explicitly selected senders through draft writes. |
go/pkg/hey/entries.go |
Adds sender-aware reply draft creation. |
go/pkg/hey/drafts_test.go |
Tests explicit sender propagation and validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks for this, and apologies that it sat while the same problem was being fixed from another direction. The shape you proposed has landed on That leaves nothing in this branch that |
Summary
CreateReplyDraftWithSenderwhile retaining the existing default-sender behavior for current callersTesting
mise exec -- make checkgo test -race -count=1 ./...GOTOOLCHAIN=go1.26.6 govulncheck ./...Summary by cubic
Preserves an explicitly selected sender across draft create, update, send, and reply-draft flows, instead of always falling back to the identity's default sender.
ActingSenderIDtoDraftContentfor message drafts; zero keeps the default-sender behavior.CreateReplyDraftWithSenderfor reply drafts while existing callers keep using the default sender.Looks good!
Written for commit baa9c85. Summary will update on new commits.