✨ feat: emit app_startup.duration_ms alongside the seconds value (0.1.18) - #7
Open
nitinstp23 wants to merge 1 commit into
Open
nitinstp23 wants to merge 1 commit into
nitinstp23 wants to merge 1 commit into
Conversation
app_startup.duration carried seconds under an unsuffixed key, the same ambiguity that produced the 1000x ANR display bug fixed in 0.1.17. Every app_startup span (native cold and warm, web cold and bfcache warm) now also carries app_startup.duration_ms. The seconds key is kept because RUM plugins before 0.1.34 read only that one; backends coalesce the ms key over seconds * 1000. Also corrects docs/configuration.md (no hot start exists) and the 0.1.8 changelog entry, which named attribute keys the SDK never emitted. Version 0.1.18.
nimishgj
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_startup.durationcarries seconds under an unsuffixed key — the same ambiguity that produced the 1000x ANR display bug fixed in 0.1.17 by renaming toanr.duration_ms. It bit again on snabbit ("Avg Cold Start 0.700 ms").Every
app_startupspan now also carriesapp_startup.duration_ms. Unlike ANR, the seconds key is kept: RUM plugins before 0.1.34 read onlyapp_startup.duration, so dropping it would blank their startup panels. Backends coalesce the ms key overseconds * 1000.Changes
src/core/attributes.ts:APP_STARTUP_DURATION_MS = 'app_startup.duration_ms'(pinned inattributes.test.ts).src/native/index.ts, reusesfbcMs), native warm (lifecycle.ts), web cold (Math.round(duration * 1000)) and web bfcache warm (0).docs/configuration.md:enableStartupTrackingclaimed a "hot" start that does not exist; now states the semantics and both keys.CHANGELOG.md: the 0.1.8 entry namedapp.startup.type/app.startup.duration_seconds, which were never emitted; corrected in place with a note. New 0.1.18 entry.package.json, lockfile root entries,scope.ts).Verification
vitest run: 294 passed.tsc --noEmitclean for bothtsconfig.jsonandtsconfig.native.json. Prettier clean.Related
app_startup.duration_mswith a seconds fallback