chore: pull pre-built GHCR images on VM instead of building locally - #72
Open
barab2002 wants to merge 2 commits into
Open
chore: pull pre-built GHCR images on VM instead of building locally#72barab2002 wants to merge 2 commits into
barab2002 wants to merge 2 commits into
Conversation
- docker-compose.prod.yml: replace build sections with GHCR image refs - publish.yml: pass VITE_ Firebase vars as build-args from GitHub secrets Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-compose.prod.yml: replacedbuild:sections withimage:refs pointing to GHCR (ghcr.io/barab2002/knownet-api:latestandghcr.io/barab2002/knownet-client:latest)publish.yml: addedbuild-argsto pass VITE_ Firebase env vars (from GitHub secrets) when building the client imageBefore merging
Add these 4 secrets to the repo (Settings → Secrets and variables → Actions):
VITE_FIREBASE_API_KEYVITE_FIREBASE_AUTH_DOMAINVITE_FIREBASE_PROJECT_IDVITE_FIREBASE_APP_IDOn the VM after merge
🤖 Generated with Claude Code