Repository navigation
feat: docs UI text and search in the page's language - #103
Merged
Merged
Conversation
Fumadocs' own text (Search, On this page, sidebar, code-block and 404 labels) was English on translated docs pages, and the search dialog searched the English index. RootProvider now gets Fumadocs UI translations for es, ja and ar (all 49 strings) and the page's locale, which the search dialog passes to /api/search.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #96: the last code item, Fumadocs UI strings and search language.
Before
On `/ja/docs/…` the page content was Japanese, but Fumadocs' own interface was English ("Search", "On this page", sidebar, code-block and 404 labels). The search dialog also queried the English index, so searching インストール on a Japanese page found nothing useful.
Change
Verified (headless Chromium, `next start`)
Lint, `format:check`, typecheck, tests, `build`, `build:lib` and `test:pack` all pass.