Skip to content

chore: move Algolia search keys to environment variables #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaque-bock-azion wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −17
Open

chore: move Algolia search keys to environment variables #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Algolia DocSearch (search-only credentials, exposed to the client)
PUBLIC_ALGOLIA_APP_ID=
PUBLIC_ALGOLIA_SEARCH_KEY=

# GitHub token used to fetch contributors/authors lists
PUBLIC_GITHUB_TOKEN=
2 changes: 2 additions & 0 deletions .github/workflows/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:
run: |
export NODE_OPTIONS="--max-old-space-size=8120"
export PUBLIC_GITHUB_TOKEN="${{ secrets.GH_PACKAGES_SECRET }}"
export PUBLIC_ALGOLIA_APP_ID="${{ secrets.PUBLIC_ALGOLIA_APP_ID }}"
export PUBLIC_ALGOLIA_SEARCH_KEY="${{ secrets.PUBLIC_ALGOLIA_SEARCH_KEY }}"
Comment on lines 32 to +35

@bruno-andrade-azion bruno-andrade-azion Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those exports are not the best way to do this. My suggestion is to use env property of the github actions.

pnpm run build:dev
- name: 'AUTH Google Cloud'
uses: 'google-github-actions/auth@v2'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ jobs:
run: |
export NODE_OPTIONS="--max-old-space-size=8120"
export PUBLIC_GITHUB_TOKEN="${{ secrets.GH_PACKAGES_SECRET }}"
export PUBLIC_ALGOLIA_APP_ID="${{ secrets.PUBLIC_ALGOLIA_APP_ID }}"
export PUBLIC_ALGOLIA_SEARCH_KEY="${{ secrets.PUBLIC_ALGOLIA_SEARCH_KEY }}"
Comment on lines 40 to +43

@bruno-andrade-azion bruno-andrade-azion Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same about env vs exports

pnpm run build:prod

- name: UPDATE Algolia data
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/stage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:
run: |
export NODE_OPTIONS="--max-old-space-size=8120"
export PUBLIC_GITHUB_TOKEN="${{ secrets.GH_PACKAGES_SECRET }}"
export PUBLIC_ALGOLIA_APP_ID="${{ secrets.PUBLIC_ALGOLIA_APP_ID }}"
export PUBLIC_ALGOLIA_SEARCH_KEY="${{ secrets.PUBLIC_ALGOLIA_SEARCH_KEY }}"
Comment on lines 32 to +35

@bruno-andrade-azion bruno-andrade-azion Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samo about env vs exports

pnpm run build:stage
- name: 'AUTH Google Cloud'
uses: 'google-github-actions/auth@v2'
Expand Down
3 changes: 0 additions & 3 deletions env/consts.development.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ export const ASSETS_URL = 'https://z4azz7gp65.map.azionedge.net';
export const FAVICON_URL = 'https://z4azz7gp65.map/assets/images/favicon.png';
export const FONTS_URL = 'https://fonts.azion.com';

export const ALGOLIA_ID = 'PYJUZH6VNQ';
export const ALGOLIA_APIKEY = '7c1795c333053265edd2aeb199745797';

// Analytics Configuration
export const ANALYTICS_WRITE_KEY = 'YUr3hmFXyFN1n2dXL7pp1DXilTzgUAIT';
export const ANALYTICS_PROXY_URL = 'https://www.azion.com/api/segment-proxy';
3 changes: 0 additions & 3 deletions env/consts.localhost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ export const ASSETS_URL = 'http://localhost:4321';
export const FAVICON_URL = 'https://www.azion.com/assets/images/favicon.png';
export const FONTS_URL = 'https://fonts.azion.com';

export const ALGOLIA_ID = 'PYJUZH6VNQ';
export const ALGOLIA_APIKEY = '7c1795c333053265edd2aeb199745797';

// Analytics Configuration
export const ANALYTICS_WRITE_KEY = '';
export const ANALYTICS_PROXY_URL = '';
3 changes: 0 additions & 3 deletions env/consts.production.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ export const ASSETS_URL = 'https://www.azion.com';
export const FAVICON_URL = 'https://www.azion.com/assets/images/favicon.png';
export const FONTS_URL = 'https://fonts.azion.com';

export const ALGOLIA_ID = 'PYJUZH6VNQ';
export const ALGOLIA_APIKEY = '7c1795c333053265edd2aeb199745797';

// Analytics Configuration
export const ANALYTICS_WRITE_KEY = 'YUr3hmFXyFN1n2dXL7pp1DXilTzgUAIT';
export const ANALYTICS_PROXY_URL = 'https://www.azion.com/api/segment-proxy';
3 changes: 0 additions & 3 deletions env/consts.stage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ export const ASSETS_URL = 'https://52082s.ha.azioncdn.net';
export const FAVICON_URL = 'https://52082s.ha.azioncdn.net/assets/images/favicon.png';
export const FONTS_URL = 'https://fonts.azion.com';

export const ALGOLIA_ID = 'PYJUZH6VNQ';
export const ALGOLIA_APIKEY = '7c1795c333053265edd2aeb199745797';

// Analytics Configuration
export const ANALYTICS_WRITE_KEY = 'YUr3hmFXyFN1n2dXL7pp1DXilTzgUAIT';
export const ANALYTICS_PROXY_URL = 'https://www.azion.com/api/segment-proxy';
3 changes: 0 additions & 3 deletions src/consts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ export const ASSETS_URL = 'http://localhost:4321';
export const FAVICON_URL = 'https://www.azion.com/assets/images/favicon.png';
export const FONTS_URL = 'https://fonts.azion.com';

export const ALGOLIA_ID = 'PYJUZH6VNQ';
export const ALGOLIA_APIKEY = '7c1795c333053265edd2aeb199745797';

// Analytics Configuration
export const ANALYTICS_WRITE_KEY = '';
export const ANALYTICS_PROXY_URL = '';
4 changes: 2 additions & 2 deletions src/layouts/BaseLayout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ const translatedPages = await (async (c) => {
<Fragment slot="dialog">
<AlgoliaDialog
client:only="vue"
algoliaAppId="PYJUZH6VNQ"
algoliaApiKey="7c1795c333053265edd2aeb199745797"
algoliaAppId={import.meta.env.PUBLIC_ALGOLIA_APP_ID}
algoliaApiKey={import.meta.env.PUBLIC_ALGOLIA_SEARCH_KEY}
algoliaIndex={algoliaIndex}
algoliaModel={algoliaModel}
inputPlaceholder={algoliaInputPlaceholder}
Expand Down