fix: repair the tsc build broken by interruptAppServerTurn's JSDoc/param mismatch

[axisrow]

Summary

npm run build (tsc -p tsconfig.app-server.json) currently fails on main:

plugins/codex/scripts/lib/codex.mjs(1209,53): error TS2339: Property 'threadId' does not exist on type '{}'.
plugins/codex/scripts/lib/codex.mjs(1209,63): error TS2339: Property 'turnId' does not exist on type '{}'.
plugins/codex/scripts/lib/codex.mjs(1209,71): error TS2339: Property 'timeoutMs' does not exist on type '{}'.

interruptAppServerTurn's second parameter is destructured directly in the signature ({ threadId, turnId, timeoutMs } = {}), while the JSDoc above it types a parameter named options. TS's JSDoc-to-signature binding matches by parameter name, not shape, so the destructuring pattern doesn't pick up the JSDoc type — TS instead infers the parameter's type from its = {} default (i.e. {}), then rejects every property access on the destructured names.

This landed via f67a09f (merged in #49) without a build check catching it — npm test alone doesn't run tsc. Noticed while validating #50; splitting the fix out separately since it's unrelated to that PR's broker work.

Fix: destructure inside the function body instead of the signature — the same pattern CodexAppServerClient#request already uses in app-server.mjs — so the JSDoc-typed options parameter name lines up with the actual parameter. No behavior change: same defaulting (options = {}), same property reads, just moved one line down into the body.

Test plan

• Reproduced the three tsc errors on a clean main checkout (reverted this change, re-ran npm run build), then re-applied to confirm it's clean.
• npm run build — clean, no errors.
• npm test — 189/189 passing (all call sites of interruptAppServerTurn pass an object literal, e.g. { threadId, turnId }, which is unaffected by moving the destructuring into the body).

No version bump (build-only fix, no behavior change).

[axisrow]

@codex review PR #51 at exact head f6a307d.

Focus on critical issues: bugs, security vulnerabilities, logical errors, data loss risks, performance problems. Do NOT nitpick style, naming conventions, minor formatting, or subjective preferences — only flag issues that could break functionality or cause real harm in production.

Context: this PR repairs the tsc build, which is currently red on main with three TS2339 errors at plugins/codex/scripts/lib/codex.mjs:1209. The cause is that interruptAppServerTurn destructures its second parameter directly in the signature ({ threadId, turnId, timeoutMs } = {}) while the JSDoc above types a parameter named options — TS binds JSDoc to parameters by name, not by shape, so the destructuring pattern never picks up the JSDoc type and TS infers {} from the default.

The fix moves the destructuring into the function body so the JSDoc-typed options name lines up with the actual parameter — the same pattern CodexAppServerClient#request already uses in app-server.mjs. Claimed to be behavior-neutral: same defaulting, same property reads, one line lower.

Specifically worth checking:

• Is the change genuinely behavior-neutral, or does moving the destructuring alter defaulting/evaluation order in any reachable case?
• Are all call sites of interruptAppServerTurn unaffected?

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: f6a307d9d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".