Skip to content

gate.sh isolated-build list is hand-maintained; new crates escape it #38

Description

@GeneralPawz

Problem

The isolated-build loop in scripts/gate.sh is a hand-written crate list. A new
workspace member is not added automatically, so it silently escapes the check
that it builds standalone.

Found while adding axiolid-exact-compile-contract in #37: the gate passed
without ever building the new crate in isolation. I added it by hand, which is
exactly the step the next person will forget.

Done when

The list is derived from cargo metadata rather than maintained by hand, or a
check fails when a workspace member is missing from it.

Verification

Add a throwaway crate, confirm the gate fails until it is covered.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

needs-triageFiled but not yet accepted, sized, or scheduled

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions