feat: track explicit debugger and profiler configuration - #6202
Open
nargokul wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
debugger_hook_configandprofiler_configwere provided directly to an estimator before SDK defaults and training preparation transform those values.x-debuggerHookConfigExplicitlyProvidedandx-profilerConfigExplicitlyProvidedonestimator.fit.Testing done:
PYTHONPATH=/tmp/sagemaker-v2-test-deps:src python -m pytest -q tests/unit/test_estimator.py(276 passed)PYTHONPATH=/tmp/sagemaker-v2-test-deps:src python -m pytest -q tests/unit/sagemaker/telemetry/test_telemetry_logging.py(19 passed)git diff --checkMerge Checklist
General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.