splitting Schema into a base class with a builder and factories - #3895
Draft
pulimsr wants to merge 1 commit into
Draft
splitting Schema into a base class with a builder and factories#3895pulimsr wants to merge 1 commit into
pulimsr wants to merge 1 commit into
Conversation
sbiscigl
reviewed
Aug 13, 2026
| virtual bool IsMember() const { return false; } | ||
| virtual Aws::String GetMemberName() const { return {}; } | ||
| virtual int GetMemberIndex() const { return 0; } | ||
| virtual const Schema* GetMemberTarget() const { return nullptr; } |
Collaborator
There was a problem hiding this comment.
returning a pointer, especially when the default case is nullptr is sketchy, lets return a optoinal of a shared pointer. to represent that it is missing, and to lifetime extend the pointer being returned.
| // spent. Move-only; obtained from Schema::StructureBuilder and friends. | ||
| class SMITHY_API SchemaBuilder { | ||
| public: | ||
| ~SchemaBuilder(); |
| if (it == m_nameToIndex.end()) { | ||
| return nullptr; | ||
| } | ||
| return m_members[it->second].get(); |
Collaborator
There was a problem hiding this comment.
dont use the [] operator on a map, it has surprising results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.