Smithy Migration C2j Parity

[sbaluja]

Issue #, if available:

Description of changes:

Check all that applies:

• Did a review by yourself.
• Added proper tests to cover this PR. (If tests are not applicable, explain.)
• Checked if this PR is a breaking (APIs have been changed) change.
• Checked if this PR will not introduce cross-platform inconsistent behavior.
• Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

• Linux
• Windows
• Android
• MacOS
• IOS
• Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[sbiscigl]

idiotmatic java would import java.util.List and then just use List<> in the code. and yeah in c++ its idiotmatic to use std:: instead of using the whole name space. so they different convention wise in this,

[sbiscigl]

so something im noticing here is that you pass a CppWriter to each method this kind of gives me the notion that writer should be a member and not a parameter, is it possible to create a accessor like

public interface Renderer {
    Writer writer();

    default void foo() {
        writer().write("foo");
    }

    void bar();
}

public final class MyRenderer implements Renderer {
    private final Writer writer;

    MyRenderer(Writer writer) { this.writer = writer; }

    @Override
    public Writer writer() {
        return writer;
    }

    @Override
    void bar() {
        writer().write("foo");
    }
}

to avoid passing the param each time

[sbiscigl]

not a big fan of continues, or else do something. we could invert the if statement then inside the block add the member to builder, same logically, and avoids the continue

[sbiscigl]

same comment here and it'll be the last time i leave it, it feels like a lot of these classes are along the lines of

class Renderer {
  private Renderer() {}

  Collection<...> PrepareSomeThingsToWrite() {
    // create a list of something to write
  }

  void WriteSomething(Writer writer) {
    var thingsToWrite = PrepareSomeThingsToWrite();
    writer.write(thingsToWrite)
  }
}

i think writer in this cases is member on the top level class, and that the Write functions are public, and the Prepare functions are private.

class Renderer {
  Writer writer;

  private Renderer(Writer writer) {
    writer = writer
  }

  private Collection<...> PrepareSomeThingsToWrite() {
    // create a list of something to write
  }

  public void WriteSomething(Writer writer) {
    var thingsToWrite = PrepareSomeThingsToWrite();
    writer.write(thingsToWrite)
  }
}

[sbiscigl]

nit: formatting here seems weird

[sbiscigl]

invert if and avoid the continue