Skip to content

fix: drain deadlock on Node.js 24.16+ by setting customer highWaterMark on OutgoingMessage - #202

Merged
maxday merged 1 commit into
nodejs24.xfrom
maxday/fix-drain-deadlock
Nov 9, 2026
Merged

maxday merged 1 commit into
nodejs24.xfrom
maxday/fix-drain-deadlock

Conversation

@maxday

@maxday maxday commented Oct 23, 2026

Copy link
Copy Markdown
Member

On Node.js 24.16+, response streaming can deadlock during drain. We now set the customer-supplied highWaterMark on the OutgoingMessage so backpressure is applied correctly and the stream drains as expected. Adds regression tests covering the drain path in response-stream.test.ts.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maxday
maxday merged commit 631d461 into nodejs24.x Nov 9, 2026
4 checks passed
@maxday
maxday deleted the maxday/fix-drain-deadlock branch November 9, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants