Skip to content

ci: add PR status labels and bump issue triage - #899

Open
yaythomas wants to merge 1 commit into
mainfrom
ci/pr-status-labels
Open

yaythomas wants to merge 1 commit into
mainfrom
ci/pr-status-labels

Conversation

@yaythomas

Copy link
Copy Markdown
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Moves two workflows to CI v0.7.0, pinned to commit c28fdc7.

  • PR status labels (new). Adds the shared workflow from CI #88: add PR status labels workflow. It adds needs-review to a new pull request whose author has no write access. When the author pushes, or the pull request is marked ready for review, it replaces changes-requested with needs-review. The job checks out no pull request code, and its token has only contents: read and pull-requests: write.
  • Issue triage, v0.5.0 to v0.7.0. No triage run here has succeeded since 2026-09-02. The latest triage run, on 2026-11-19 failed because the model API rejects uniqueItems: true in the v0.5.0 response schema, so the model labeled nothing and the fallback added needs-triage. v0.7.0 drops uniqueItems (CI #83: drop uniqueItems from label schema) and skips needs-triage on issues labeled project (CI #87: skip needs-triage on project issues).

Design

  • Design note: CI #88: add PR status labels workflow and pr-status-labels.md, which describes the behavior.
  • Simpler options considered: none, because this repository gains no logic, only a caller and a pin.
  • Root cause of the triage failures: strict response schemas do not support uniqueItems, and the v0.5.0 schema uses it.
  • Net change: +15 −1 lines of workflow configuration. No public API change.

Assumptions

  • The new workflow first runs after this merges, because pull_request_target runs in the context of the default branch (GitHub docs).
  • pull-requests: write is enough to add and remove a pull request's labels (GitHub App permissions). Unverified in a run: no repository has run the workflow on a real pull request yet. A dry run with writes disabled checked its decisions against every open pull request in the consuming repositories.

Decisions not covered by the issue or the design note

  • The job runs on ubuntu-latest, as closed-issue-comment does, because it runs no model.
  • Only issue triage moves to v0.7.0. The other shared workflows keep their pins.

Testing

actionlint passes on the changed workflow files. The labeling logic has 36 unit tests in the CI repository.

Add the shared PR status labels workflow from CI v0.7.0. It adds
needs-review to a new pull request whose author has no write access,
and replaces changes-requested with needs-review when the author
pushes or the pull request is marked ready for review.

Move issue triage from CI v0.5.0 to v0.7.0. The model API rejects
the uniqueItems keyword in the v0.5.0 response schema, so new issues
get only the fallback needs-triage label. v0.7.0 drops the keyword
and skips needs-triage on issues labeled project.
@yaythomas
yaythomas requested a review from a team November 19, 2026 22:29
@yaythomas
yaythomas deployed to ai-pr-review-runtime November 19, 2026 22:29 — with GitHub Actions Active
@yaythomas
yaythomas deployed to ai-pr-review-runtime November 19, 2026 22:30 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No confirmed actionable findings in the supplied diff. Static inspection only: tests were not run, and the referenced shared-workflow implementations and upstream test evidence were unavailable locally.

Reviewed commit 43ee00cacacd834c23d2a798a1bd6672ecba6b14. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 43ee00ca Deployed Nov 19, 2026 by yaythomas via ai-pr-review / Codex review / Generate Codex review #2937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant