Skip to content

ci: notify Slack on closed issue comments - #894

Merged
SilanHe merged 3 commits into
mainfrom
ci/closed-issue-comment-notify
Nov 18, 2026
Merged

SilanHe merged 3 commits into
mainfrom
ci/closed-issue-comment-notify

Conversation

@SilanHe

@SilanHe SilanHe commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Adds the shared closed-issue-comment workflow from aws-durable-execution-ci#86 (v0.6.0, pinned to commit e04e810). It pings the issue Slack channel when an outside user comments on a closed issue.

Design note

Problem. Nobody sees comments on closed issues. In the last 6 months one real bug report on a closed issue got no reply (sdk-js#674, day 18 after close).

Cause. GitHub only notifies people who subscribed. No workflow in the shared CI repo runs on issue_comment. The stale-issue closer also asks authors to comment on closed issues.

Options.

  • Reply on close with a fixed message (closed-issue-message). The team still never sees the comment.
  • Bot reply on each outside comment. Needs a script and issues: write, and clashes with the stale closer's "comment and we will reopen" text.
  • Lock old closed issues. Blocks real reports.
  • Simplify existing logic: no existing workflow can take this, so none is changed.
  • Slack ping only, through the existing shared workflow and SLACK_WEBHOOK_URL_ISSUE.

Chosen. Slack ping only. It needs no script, no token permissions and no checkout, and it posts nothing on GitHub.

Removes. Nothing.

Decisions not covered by the task

  • Comments from owners, members, collaborators and bots are ignored.
  • Every other new comment on a closed issue pings, with no delay.
  • The job runs on ubuntu-latest.

🤖 AI-assisted comment

@SilanHe
SilanHe marked this pull request as ready for review November 17, 2026 23:10
@SilanHe
SilanHe requested a review from a team November 17, 2026 23:10
@SilanHe
SilanHe deployed to ai-pr-review-runtime November 17, 2026 23:10 — with GitHub Actions Active
@SilanHe
SilanHe deployed to ai-pr-review-runtime November 17, 2026 23:11 — with GitHub Actions Active
@@ -0,0 +1,13 @@
name: Closed Issue Comment

This comment was marked as outdated.

@github-actions

This comment has been minimized.


jobs:
closed-issue-comment:
uses: aws/aws-durable-execution-ci/.github/workflows/closed-issue-comment.yml@e04e810d6d7e452377bbefc04f007ad7373d19e2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we release a new version of CI repo and pin the released version?

@SilanHe
SilanHe deployed to ai-pr-review-runtime November 18, 2026 18:19 — with GitHub Actions Active
Comment on lines +10 to +11
closed-issue-comment:
uses: aws/aws-durable-execution-ci/.github/workflows/closed-issue-comment.yml@e04e810d6d7e452377bbefc04f007ad7373d19e2 # v0.6.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex AI review · Finding arf_v1_fzhse24fidpq6u7qaldkguyzo3

[P2] Supply the required design note for this new feature

Rule 3, “Write a design note before the code,” applies to the new closed-issue notification behavior. The description identifies the shared workflow and pin, but omits the cause, alternatives including simplification of existing notification logic, selection rationale, and what the change removes. This leaves the approach unevaluated under the repository’s rules. Return to the design phase under Rule 8, step 6, and document the required design before proceeding.

To suppress repeats, reply /ai verdict deferred, /ai verdict false-positive, or /ai verdict out-of-scope on the first nonblank line. Add rationale on later lines. A new /ai verdict accepted allows future repeats again.

@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

One approach finding remains at .github/workflows/closed-issue-comment.yml:10. Residual test risk: the external reusable workflow and Slack delivery were not exercised.

Reviewed commit 39191e0a7c58ba50667b4f5155674ca8f0b08d9d. Workflow run

@SilanHe
SilanHe merged commit 067dbe0 into main Nov 18, 2026
15 checks passed
@SilanHe
SilanHe deleted the ci/closed-issue-comment-notify branch November 18, 2026 18:54

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 39191e0a Deployed Nov 18, 2026 by SilanHe via ai-pr-review / Codex review / Generate Codex review #2919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants