Repository navigation
ci: notify Slack on closed issue comments - #894
Conversation
| @@ -0,0 +1,13 @@ | |||
| name: Closed Issue Comment | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
|
|
||
| jobs: | ||
| closed-issue-comment: | ||
| uses: aws/aws-durable-execution-ci/.github/workflows/closed-issue-comment.yml@e04e810d6d7e452377bbefc04f007ad7373d19e2 |
There was a problem hiding this comment.
Should we release a new version of CI repo and pin the released version?
| closed-issue-comment: | ||
| uses: aws/aws-durable-execution-ci/.github/workflows/closed-issue-comment.yml@e04e810d6d7e452377bbefc04f007ad7373d19e2 # v0.6.0 |
There was a problem hiding this comment.
Codex AI review · Finding arf_v1_fzhse24fidpq6u7qaldkguyzo3
[P2] Supply the required design note for this new feature
Rule 3, “Write a design note before the code,” applies to the new closed-issue notification behavior. The description identifies the shared workflow and pin, but omits the cause, alternatives including simplification of existing notification logic, selection rationale, and what the change removes. This leaves the approach unevaluated under the repository’s rules. Return to the design phase under Rule 8, step 6, and document the required design before proceeding.
To suppress repeats, reply /ai verdict deferred, /ai verdict false-positive, or /ai verdict out-of-scope on the first nonblank line. Add rationale on later lines. A new /ai verdict accepted allows future repeats again.
Codex AI reviewOne approach finding remains at Reviewed commit |
Adds the shared closed-issue-comment workflow from aws-durable-execution-ci#86 (v0.6.0, pinned to commit
e04e810). It pings the issue Slack channel when an outside user comments on a closed issue.Design note
Problem. Nobody sees comments on closed issues. In the last 6 months one real bug report on a closed issue got no reply (sdk-js#674, day 18 after close).
Cause. GitHub only notifies people who subscribed. No workflow in the shared CI repo runs on
issue_comment. The stale-issue closer also asks authors to comment on closed issues.Options.
closed-issue-message). The team still never sees the comment.issues: write, and clashes with the stale closer's "comment and we will reopen" text.SLACK_WEBHOOK_URL_ISSUE.Chosen. Slack ping only. It needs no script, no token permissions and no checkout, and it posts nothing on GitHub.
Removes. Nothing.
Decisions not covered by the task
ubuntu-latest.🤖 AI-assisted comment