Skip to content

Set exception on rename failure - #10654

Merged
hssyoo merged 1 commit into
crt-config-v2from
crt-config/rename-failure
Sep 17, 2026
Merged

Set exception on rename failure#10654
hssyoo merged 1 commit into
crt-config-v2from
crt-config/rename-failure

Conversation

@hssyoo

@hssyoo hssyoo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
  1. CRT coordinator sets done() on the future when download from S3 finishes
  2. This triggers the RenameTempFileHandler handler
  3. But if the rename operation fails, it calls the coordinator's set_exception()
  4. But because the future is already done, it doesn't throw an exception

This PR fixes the bug by setting set_exception(override=True), to override the done status and raise an exception

@hssyoo
hssyoo requested a review from a team as a code owner September 16, 2026 19:02
@hssyoo
hssyoo force-pushed the crt-config/rename-failure branch from 2199c71 to 06290bd Compare September 17, 2026 13:25
@hssyoo
hssyoo force-pushed the crt-config/rename-failure branch from 06290bd to 48c9414 Compare September 17, 2026 13:33
@hssyoo
hssyoo merged commit 368b0b3 into crt-config-v2 Sep 17, 2026
108 of 109 checks passed
@hssyoo
hssyoo deleted the crt-config/rename-failure branch September 17, 2026 13:43
hssyoo added a commit that referenced this pull request Sep 17, 2026
@hssyoo
Set exception on rename failure (#10654)
97410b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashovlin ashovlin ashovlin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hssyoo @ashovlin