Scope ssm_document to SSM instances; add non-SSM OS variants - #748
Open
bhavya76 wants to merge 1 commit into
Open
Scope ssm_document to SSM instances; add non-SSM OS variants#748bhavya76 wants to merge 1 commit into
bhavya76 wants to merge 1 commit into
Conversation
ssm_document manages the CloudWatch agent through an SSM document, so it needs the SSM agent present on the instance. A few integration AMIs (rocky-linux-8, debian-12, debian-13) do not keep the SSM agent, so the test's SSM-readiness wait times out on them. SSM is now the default for those OSes (handled in the image recipes). Add explicit -withoutSSM AMI variants to preserve non-SSM coverage, run ssm_document on all SSM-capable instances, and exclude the -withoutSSM variants. All other tests continue to run on every instance. - add rocky-linux-8-withoutSSM, debian-12-withoutSSM, debian-13-withoutSSM rows - tighten rocky-linux-8 AMI name filter so it does not match the -withoutSSM image - exclude the -withoutSSM OSes from ./test/ssm_document
bhavya76
marked this pull request as ready for review
August 26, 2026 15:13
AshuSrv
reviewed
Aug 26, 2026
AshuSrv
left a comment
AshuSrv
left a comment
Contributor
There was a problem hiding this comment.
Can we run this branch against the actual agent to test the changes
bhavya76
added
github_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run the ssm_document integration test only on SSM-enabled instances, and add non-SSM variants of the OSes that previously had no SSM agent.
Why
ssm_document drives the CloudWatch agent via an SSM document and therefore requires a registered SSM agent. rocky-linux-8, debian-12 and debian-13 image recipes strip the SSM agent at bake time, so the readiness wait times out and the test fails during setup (never reaching the code under test).
Changes