Harden local UI startup - #107
Draft
amirgholipour wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
127.0.0.1by default, with an explicitHOSToverride.Why this change is proposed
Two startup-path details make first-run development unreliable. The server currently binds using the platform default, which may expose a local development service beyond loopback. Separately, the first chat message calls
realpathSyncon a log file before that file exists, so a brand-new session can fail before its first append.The server now has a safe loopback default, and the future log path is resolved and checked before creation.
Benefits
HOST.Validation
main.Authored by Saeed Kasmani (
amirgholipour).