Repository navigation
Conversation
Datasource adapters cap success and error bodies before parsing, fail closed on missing explicit instance IDs, probe the real bounded query operation, and report partial or unverified results instead of claiming absence. Prometheus/Mimir enforce the saved execution ceiling inside the connector; other kinds apply HTTP response limits, and the UI shows the effective limit. Jaeger limits are clamped with requested/returned counts. Optional Jaeger/Dynatrace VPC attachment and a configurable Mimir API prefix stay default-off. Custom MCP connections pin the validated address while preserving Host/SNI, and reject every redirect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Atom-oh
had a problem deploying
to
ci-review-auto
October 18, 2026 06:57 — with
GitHub Actions
Failure
| context = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER) | ||
| context.load_cert_chain(str(certificate), str(key)) | ||
| context.set_servername_callback(lambda sock, name, ctx: seen.update(sni=name)) | ||
| server.socket = context.wrap_socket(server.socket, server_side=True) |
🤖 AI Code Review (two independent reviewers)Reviewer responses: none Status: BLOCKED — input coverage incomplete; models were not called Review input incomplete: diff exceeds 128 KiB; split the change or implement complete bounded review batches. No models were called; no code verdict is available. Triggered by commit |
This was referenced Oct 18, 2026
Contributor
Author
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens the eight datasource HTTP adapters and the administrator-managed custom MCP path. It has two commits.
1. Verify datasource access and disclose incomplete results
collectionStatus: partial.2. Bound and verify external connections
jaeger_vpc_enabled/dynatrace_vpc_enabled(defaultfalse, requireagentcore_enabled && integrations_enabled). Mimir's Prometheus API prefix is configurable. Shared default datasources are labelled as shared in the API, UI and docs.agent/pinned_http.py) pin the validated address while preserving Host/SNI and credentials, and reject every redirect. httpx/httpcore are pinned to the versions the SNI extension was tested against.docs/reference/external-connections.md(indexed in the reference README). The docs-site datasource guides (ko/en/ja/zh) and the existing CHANGELOG entries are amended in place.Release order
The Lambda producers and the helper must ship before the Web/UI that reads their completion metadata. The AgentCore image with the pinned transport is a separate Deploy AgentCore. The VPC flags stay
falseuntil an operator reviews a saved plan. This PR performs no deployment or flag activation.Tests
bash scripts/v2/merge-verify.shon Python 3.12 (rebased ondevbaea6e9): web vitest PASS, Terraform fmt PASS, deployment Node tests PASS. In the Python stage, the only failures aretest_review_codec_sandbox.py/test_pr_review_head_images.py, which need a preparedAWSOPS_REVIEW_CODEC_STATEthat this host doesn't have. The same failures occur on thedevbaseline.agent/test_pinned_http.pyneeds Python ≥ 3.11 (asyncio.timeout) and passes 13/13 on 3.12.terraform test -filter=tests/runtime_iam.tftest.hcl(mock provider) → 9 passed.🤖 Generated with Claude Code