-
Notifications
You must be signed in to change notification settings - Fork 46
fix(deps): re-resolve browserslist to clear two HIGH osv-scanner advisories blocking every PR #845
Copy link
Copy link
Closed
Labels
P1medium prioritymedium priorityapprovedWhen an issue has been approved and readyWhen an issue has been approved and readybugSomething isn't workingSomething isn't workingci-cdBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsdependenciesPull requests that update a dependency filePull requests that update a dependency filesecurityCedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVECedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVEv1Version 1Version 1
Description
Activity
Metadata
Metadata
Assignees
Labels
P1medium prioritymedium priorityapprovedWhen an issue has been approved and readyWhen an issue has been approved and readybugSomething isn't workingSomething isn't workingci-cdBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsdependenciesPull requests that update a dependency filePull requests that update a dependency filesecurityCedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVECedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVEv1Version 1Version 1
Summary
osv-scanner(required checkSecrets, deps, and workflow scan→Dependency scan (osv-scanner)) fails onmain'syarn.lock, so every PR in the repo fails that check regardless of its contents.maincarriesbrowserslist@4.28.5, which two HIGH advisories published on 2026-09-01 apply to.Same shape as #636: the advisories landed after PRs were last scanned, so a PR that was green at open time goes red on its next run with no change to the branch. Observed on #681 (otherwise approved) and #831; #831's
security-prpassed at 13:42 and #681's failed at 17:28 on the same lockfile state.Affected package
osv-scanner scan --lockfile agent/uv.lock --lockfile yarn.lock— 1 package, 2 known vulns (2 High):Fix
Lockfile-only re-resolve, as in #636/#637.
browserslistis transitive — no direct entry in anypackage.jsonand noresolutionspin — soyarn upgrade browserslistis a no-op under yarn v1. Dropping the pinned stanza and reinstalling lets it resolve within the existing^4.24.0range, landing 4.28.8.No
package.jsonchange, so noresolutionsentry and nothing to mirror intointegrations/jira-forge-app(that project'soverridesare brace-expansion/fast-uri/undici and it does not consume browserslist). The 56-line delta is confined to browserslist and the five data packages it pins:baseline-browser-mapping,caniuse-lite,electron-to-chromium,node-releases,update-browserslist-db.Acceptance
mise run security:depsreports no issuesmise run buildgreen, including the Astro docs build (the actual consumer of browserslist)security-prandbuild (agentcore)green on the fix PRNotes
Filed retroactively to give #844 the audit trail #636 set for #637 — the fix was written first because
mainwas red and blocking the queue. Raised as a review nit on #844 by @ayushtr-aws.Residual noted in that review, recorded here rather than acted on: with no
resolutionspin, a forced re-resolution could float browserslist again. That is ordinary transitive-dependency behaviour — the lockfile pins the exact version for all installs — so no pin is warranted.